Disable unit tests for flakyness in CircleCI - #45133
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D58948614 |
Base commit: c0b5e2e |
|
This pull request was exported from Phabricator. Differential Revision: D58948614 |
b5a2c3d to
936f52f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58948614 |
936f52f to
a3cc8a5
Compare
Summary: Pull Request resolved: #45133 Recently, CircleCI has failed pretty often due to these tests. The reason is that we migrated these jobs to M1 machines, as circleCI is deprecating intel ones, and on these machines the simulators tend to freeze. Hence, every often we get stuck when running the tests. :( We are going to move to GHA, so that should not be a big issue. ## Changelog: [Internal] - Disable unit tests in CircleCI to improve CI robustness Reviewed By: cortinico Differential Revision: D58948614
|
This pull request was exported from Phabricator. Differential Revision: D58948614 |
a3cc8a5 to
5c6a0bd
Compare
|
This pull request has been merged in 2adb389. |
|
This pull request was successfully merged by @cipolleschi in 2adb389. When will my fix make it into a release? | How to file a pick request? |
|
@cipolleschi the description of this PR details that it disables the unit tests on Circle CI and mentions that it's not a big issue since they're ran on GHA. However, this PR also disables tests on GHA as well: 2adb389#diff-12d2c3c126fcc84106dce4b6d2be2220f018661b111a5382ad6effc1047f66aeL435 and I suspect that wasn't intentional. |
Summary:
Recently, CircleCI has failed pretty often due to these tests.
The reason is that we migrated these jobs to M1 machines, as circleCI is deprecating intel ones, and on these machines the simulators tend to freeze. Hence, every often we get stuck when running the tests. :(
We are going to move to GHA, so that should not be a big issue.
Changelog:
[Internal] - Disable unit tests in CircleCI to improve CI robustness
Differential Revision: D58948614